fix(skills): trim skill search query before matching #259

Merged

karsten merged 1 commit from fix/skill-search-trim-query into main

2026-11-05 04:28:33 +00:00

karsten commented

2026-11-05 04:28:21 +00:00

Owner

Surrounding spaces, tabs or newlines in plugin_skill_search queries caused misses for otherwise matching skills; a whitespace-only query matched the whole catalog. Normalize with trim() and treat empty queries as no match.

Base: cbd29b8. Single commit b45806e.

Evidence:

Counterfactual: new test/skill-search-whitespace.test.ts 9/13 pass on cbd29b8 without the fix.
With fix: 39/39 across whitespace + skill-search/catalog/adaptive/updates suites; tsc typecheck clean.
Shipped review engine (scope all, base cbd29b8): passed, 1 round, 0 findings, fingerprint ff71bd7b1f9835d5ce58d0fe123106dcb5052746f6f87d384405ccb58878fd8f.

Surrounding spaces, tabs or newlines in `plugin_skill_search` queries caused misses for otherwise matching skills; a whitespace-only query matched the whole catalog. Normalize with `trim()` and treat empty queries as no match. Base: cbd29b8. Single commit b45806e. Evidence: - Counterfactual: new `test/skill-search-whitespace.test.ts` 9/13 pass on cbd29b8 without the fix. - With fix: 39/39 across whitespace + skill-search/catalog/adaptive/updates suites; `tsc` typecheck clean. - Shipped review engine (scope all, base cbd29b8): passed, 1 round, 0 findings, fingerprint ff71bd7b1f9835d5ce58d0fe123106dcb5052746f6f87d384405ccb58878fd8f.

karsten added 1 commit

2026-11-05 04:28:21 +00:00

fix(skills): trim skill search query before matching b45806e1eb

Surrounding spaces, tabs or newlines in plugin_skill_search queries
caused misses for otherwise matching skills. Normalize with trim() and
keep whitespace-only queries from matching the whole catalog.

Counterfactual on cbd29b8: new suite 9/13 pass without the fix; with fix
39/39 across whitespace + skill-search/catalog/adaptive/updates suites.

karsten merged commit 8d7ff2f233 into main

2026-11-05 04:28:33 +00:00

karsten referenced this pull request from a commit

2026-11-05 04:28:35 +00:00

Merge pull request 'fix(skills): trim skill search query before matching' (#259) from fix/skill-search-trim-query into main

karsten referenced this pull request

2026-11-05 04:29:04 +00:00

fix(skills): require a complete frontmatter closing fence #260