harness/core
4
0
Fork 1
Code Issues Pull requests 14 Projects Releases 200 Packages 1 Wiki Activity Actions

fix(skills): require a complete frontmatter closing fence #260

Merged
karsten merged 1 commit from fix/skill-frontmatter-closing-fence into main 2026-11-05 04:29:12 +00:00
Conversation 0 Commits 1 Files changed 2 +49 -1
karsten commented 2026-11-05 04:29:04 +00:00
Owner
Copy link

The frontmatter regex accepted lines such as ---suffix or ---- as the closing delimiter. Require --- followed only by horizontal whitespace and a line end or EOF; LF/CRLF/EOF variants stay valid.

Base: cbd29b8 (independent of #259, no shared files). Single commit 09c5f9e.

Evidence:

  • Counterfactual: new test/skill-frontmatter-fence.test.ts 7/12 pass on cbd29b8 without the fix.
  • With fix: 38/38 across fence + skill-search/catalog/adaptive/updates suites; tsc typecheck clean.
  • Read-only probe of 10 local user skills: no acceptance changes.
  • Shipped review engine (scope all, base cbd29b8): passed, 1 round, 0 findings, fingerprint be4cba244f766d4837c09d5c1e6b932543a54264c574a8fc291e7b353c9ef704.
The frontmatter regex accepted lines such as `---suffix` or `----` as the closing delimiter. Require `---` followed only by horizontal whitespace and a line end or EOF; LF/CRLF/EOF variants stay valid. Base: cbd29b8 (independent of #259, no shared files). Single commit 09c5f9e. Evidence: - Counterfactual: new `test/skill-frontmatter-fence.test.ts` 7/12 pass on cbd29b8 without the fix. - With fix: 38/38 across fence + skill-search/catalog/adaptive/updates suites; `tsc` typecheck clean. - Read-only probe of 10 local user skills: no acceptance changes. - Shipped review engine (scope all, base cbd29b8): passed, 1 round, 0 findings, fingerprint be4cba244f766d4837c09d5c1e6b932543a54264c574a8fc291e7b353c9ef704.
The frontmatter regex accepted lines such as '---suffix' or '----' as the
closing delimiter. Require '---' followed only by horizontal whitespace
and a line end or EOF; LF/CRLF/EOF variants stay valid.

Counterfactual on cbd29b8: new suite 7/12 pass without the fix; with fix
38/38 across fence + skill-search/catalog/adaptive/updates suites.
Read-only probe of 10 local user skills: no acceptance changes.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
harness/core!260
No description provided.