fix: effective review assessments and non-repeating chat escalation #89

Merged

severus-snape merged 1 commit from fix/review-json-admin-extension into main

2026-10-26 17:58:25 +00:00

severus-snape commented

2026-10-26 17:57:57 +00:00

Collaborator

Scope

Bound review command/tool/internal prompt output; retain complete local evidence.
Make evidence-backed false-positive assessments effective on exactly reviewed bytes, including final exhausted round. Confirmed/uncertain/unassessed P0/P1 still block; P2/P3 optional.
Stop appending existing workspace escalations to every chat answer. Notify transitions separately; repeated escalation calls do not spam. Publication/merge checks retained.
Audited administrative candidate-bound budget extensions without ledger reset/history deletion/model-tool authority.
Pin published plugins commit0d631ffe2b9a9d5407704fbfa2213e1c558c4da0 (plugins PR#3 merged). All other plugin bytes unchanged.

Verification

Actual isolated candidate WITH new pinned adapter: typecheck/build pass, full512/512 tests pass, diffcheck pass. Original dirty development workspace full519/519 passed; extra recovery tests deliberately excluded from this PR.
Two explicitly operator-authorized independent reviews completed and critically counterchecked: no demonstrated P0/P1. Latest repeated-chat-warning correction followed those two reviews and is regression-tested, NOT falsely represented as independently reviewed. No third review initiated.

Nonblocking followups

P2: clipped long finding IDs in bounded summary; P2: prior prompt first8 projection can omit high-priority findings. Full evidence remains available locally.

Boundaries

Recovery/dispatcher/architecture drafts excluded. Existing unrelated recovery P1 and old live ledger left untouched, no fabricated gate approval or budget reset. This PR does not activate installed code; rollout remains GitOps-owned. Operator explicitly requested commit, push, PR, merge.

## Scope - Bound review command/tool/internal prompt output; retain complete local evidence. - Make evidence-backed false-positive assessments effective on exactly reviewed bytes, including final exhausted round. Confirmed/uncertain/unassessed P0/P1 still block; P2/P3 optional. - Stop appending existing workspace escalations to every chat answer. Notify transitions separately; repeated escalation calls do not spam. Publication/merge checks retained. - Audited administrative candidate-bound budget extensions without ledger reset/history deletion/model-tool authority. - Pin published plugins commit0d631ffe2b9a9d5407704fbfa2213e1c558c4da0 (plugins PR#3 merged). All other plugin bytes unchanged. ## Verification Actual isolated candidate WITH new pinned adapter: typecheck/build pass, full512/512 tests pass, diffcheck pass. Original dirty development workspace full519/519 passed; extra recovery tests deliberately excluded from this PR. Two explicitly operator-authorized independent reviews completed and critically counterchecked: no demonstrated P0/P1. Latest repeated-chat-warning correction followed those two reviews and is regression-tested, NOT falsely represented as independently reviewed. No third review initiated. ## Nonblocking followups P2: clipped long finding IDs in bounded summary; P2: prior prompt first8 projection can omit high-priority findings. Full evidence remains available locally. ## Boundaries Recovery/dispatcher/architecture drafts excluded. Existing unrelated recovery P1 and old live ledger left untouched, no fabricated gate approval or budget reset. This PR does not activate installed code; rollout remains GitOps-owned. Operator explicitly requested commit, push, PR, merge.

severus-snape added 1 commit

2026-10-26 17:57:57 +00:00

fix: make review assessments effective and stop repeated chat escalation bfe924ba95

severus-snape merged commit 1b4a004c32 into main

2026-10-26 17:58:25 +00:00

severus-snape referenced this pull request from a commit

2026-10-26 17:58:27 +00:00

Merge pull request 'fix: effective review assessments and non-repeating chat escalation' (#89) from fix/review-json-admin-extension into main