feat: extract completion validator into provider plugin

karsten commented

2026-11-11 18:54:45 +00:00

Owner

Implements the completion-validator extraction (not code review): minimal versioned provider contract/registry, startup PluginAPI registration, explicit completionCheck.provider selection/disable, unchanged legacy default. Task/nightly/delegated-step share one registry and preserve host authority and existing persisted shapes.

Plugin implementation published at 0df11da76fc8e5f15617fa09c7450e7f2ced5458 in plugins#91; pin includes exact new-file hash. Merge plugin PR before Core integration.

Verification: npm run typecheck passed; normal npm test passed 1897/1898, zero failures, one skipped. Four plugin tests passed. Added integration tests for selected provider, disabled evidence retention and actual failed worker precedence. Diff has no core default prompt additions, routing or model policy changes; dispatcher edits only pass registry to existing completion call. Evidence: development-evidence/completion-validator-plugin.md.

No rollout/config/restart yet. Concurrent compaction worker and original dirty checkouts untouched.

Implements the completion-validator extraction (not code review): minimal versioned provider contract/registry, startup PluginAPI registration, explicit completionCheck.provider selection/disable, unchanged legacy default. Task/nightly/delegated-step share one registry and preserve host authority and existing persisted shapes. Plugin implementation published at 0df11da76fc8e5f15617fa09c7450e7f2ced5458 in plugins#91; pin includes exact new-file hash. Merge plugin PR before Core integration. Verification: npm run typecheck passed; normal npm test passed 1897/1898, zero failures, one skipped. Four plugin tests passed. Added integration tests for selected provider, disabled evidence retention and actual failed worker precedence. Diff has no core default prompt additions, routing or model policy changes; dispatcher edits only pass registry to existing completion call. Evidence: development-evidence/completion-validator-plugin.md. No rollout/config/restart yet. Concurrent compaction worker and original dirty checkouts untouched.

karsten added 1 commit

2026-11-11 18:54:45 +00:00