Wait for the actual fullscreen viewport in the terminal layout regression #305

Merged
karsten merged 1 commit from test/await-rendered-terminal-viewport into main 2026-11-08 16:56:01 +00:00
Owner

The real post-merge Plugins compatibility run 24287 correctly failed Core test/tui.test.ts: the fullscreen test observed zero rows after an arbitrary 30ms sleep under parallel runner load. The source candidate passed, but this timing assumption is not reliable enough for unattended publication. Use Node TestContext.waitFor with a bounded five-second deadline and 10ms polls, requiring both the full viewport row count and final long-output line. Preserve every header/footer/editor/scroll assertion and explicitly assert the final line, so an old initial frame cannot masquerade as completion. Missing or incorrect rendering still fails. No runtime source, dependency, CI workflow, skipped tests, SDK version, gate or agent state changes. Typecheck, normal build, all 13 TUI tests and full Core suite pass (1605 pass, one existing optional skip). Normal full source/snapshot checks and publication follow; no manual GitHub merge for acceptance.

The real post-merge Plugins compatibility run 24287 correctly failed Core test/tui.test.ts: the fullscreen test observed zero rows after an arbitrary 30ms sleep under parallel runner load. The source candidate passed, but this timing assumption is not reliable enough for unattended publication. Use Node TestContext.waitFor with a bounded five-second deadline and 10ms polls, requiring both the full viewport row count and final long-output line. Preserve every header/footer/editor/scroll assertion and explicitly assert the final line, so an old initial frame cannot masquerade as completion. Missing or incorrect rendering still fails. No runtime source, dependency, CI workflow, skipped tests, SDK version, gate or agent state changes. Typecheck, normal build, all 13 TUI tests and full Core suite pass (1605 pass, one existing optional skip). Normal full source/snapshot checks and publication follow; no manual GitHub merge for acceptance.
Author
Owner

Exact candidate evidence: normal build + typecheck, all 13 TUI tests and complete 1606-test suite (1605 pass, one existing optional skip). Every old viewport assertion remains; the test now requires the actual final output and fails at a bounded deadline if rendering is missing. No source CI protection is disabled.

Exact candidate evidence: normal build + typecheck, all 13 TUI tests and complete 1606-test suite (1605 pass, one existing optional skip). Every old viewport assertion remains; the test now requires the actual final output and fails at a bounded deadline if rendering is missing. No source CI protection is disabled.
karsten deleted branch test/await-rendered-terminal-viewport 2026-11-08 16:56:02 +00:00
Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
harness/core!305
No description provided.