harness/core
4
0
Fork 1
Code Issues Pull requests 14 Projects Releases 206 Packages 1 Wiki Activity Actions

feat: durable session-bound inbound attachments and runtime images #282

Merged
severus-snape merged 1 commit from feat/slack-inbound-attachments into main 2026-11-06 11:12:22 +00:00
Conversation 0 Commits 1 Files changed 10 +323 -5
severus-snape commented 2026-11-06 04:05:16 +00:00
Collaborator
Copy link

Scope

Small Core-only inbound vertical slice: durable session-bound references, admission and replay validation, bounded verified file reads, actual runtime SDK image blocks, explicit non-vision model rejection. Text-only transports unchanged. No Slack activation, no outbound file uploads.

Verification after rebase on f985096

152/152 relevant tests pass, no skips, including FIFO admission in a killable subprocess, persisted inbox restoration, forged ownership/source rejection, SDK image delivery, actual local Slack gateway-to-Core fake-transport integration. Typecheck, build and diff checks pass. Optional cross-repository test explicitly ran with SLACK_GATEWAY_CANDIDATE=/home/node/work/slack-gateway; default suite does not assume another checkout.

Review

Local self-review performed; FIFO open and post-IO admission fencing findings fixed and regression tested. plugin_review invoked but returns retained unrelated review for dirty /home/node/work/core; it is NOT claimed as coverage for this candidate. No external review agents requested.

Dependencies / limits

Core independently deployable. Paired local Slack plugin requires GatewayFactoryContext.inboundAttachments=1 and must be provisioned separately after this Core is activated. docs/inbound-attachments.md records storage, trusted local parent directories, size limits and retention. No automatic blob GC, no image decoder/malware scanner, no exactly-once or live Slack success claim.

Delivery

Source publication only at PR creation. Normal merge gates and GitOps remain required; build is not live activation.

## Scope Small Core-only inbound vertical slice: durable session-bound references, admission and replay validation, bounded verified file reads, actual runtime SDK image blocks, explicit non-vision model rejection. Text-only transports unchanged. No Slack activation, no outbound file uploads. ## Verification after rebase on f985096 152/152 relevant tests pass, no skips, including FIFO admission in a killable subprocess, persisted inbox restoration, forged ownership/source rejection, SDK image delivery, actual local Slack gateway-to-Core fake-transport integration. Typecheck, build and diff checks pass. Optional cross-repository test explicitly ran with SLACK_GATEWAY_CANDIDATE=/home/node/work/slack-gateway; default suite does not assume another checkout. ## Review Local self-review performed; FIFO open and post-IO admission fencing findings fixed and regression tested. plugin_review invoked but returns retained unrelated review for dirty /home/node/work/core; it is NOT claimed as coverage for this candidate. No external review agents requested. ## Dependencies / limits Core independently deployable. Paired local Slack plugin requires GatewayFactoryContext.inboundAttachments=1 and must be provisioned separately after this Core is activated. docs/inbound-attachments.md records storage, trusted local parent directories, size limits and retention. No automatic blob GC, no image decoder/malware scanner, no exactly-once or live Slack success claim. ## Delivery Source publication only at PR creation. Normal merge gates and GitOps remain required; build is not live activation.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
harness/core!282
No description provided.