fix: keep review behaviours out of Core defaults and stabilize tests #275

Merged

karsten merged 4 commits from fix/core-review-policy-forgejo into main 2026-11-05 15:34:51 +00:00

Conversation 0 Commits 4 Files changed 10 +79 -30

karsten commented 2026-11-05 15:08:43 +00:00

Owner

Copy link

Summary

• Remove unconditional review obligation from Core defaults; retain authorization boundaries.
• Document: behaviours belong in plugins or codified extensions; Core remains clear and clean.
• Fix portable memory-worker flock, observer liveness and continuation test synchronization.
• Build test prerequisites and use short canonical temporary directories.

Verification

Typecheck and complete npm test pass on current Forgejo main: 1502 passed, 0 failed, 0 cancelled, 3 existing skips.

No deployment, remote policy changes or removal of configurable review engines. GitHub publication is handled by the existing automation.

## Summary - Remove unconditional review obligation from Core defaults; retain authorization boundaries. - Document: behaviours belong in plugins or codified extensions; Core remains clear and clean. - Fix portable memory-worker flock, observer liveness and continuation test synchronization. - Build test prerequisites and use short canonical temporary directories. ## Verification Typecheck and complete npm test pass on current Forgejo main: 1502 passed, 0 failed, 0 cancelled, 3 existing skips. No deployment, remote policy changes or removal of configurable review engines. GitHub publication is handled by the existing automation.

karsten added 3 commits 2026-11-05 15:08:44 +00:00

fix: move review rules out of core defaults and stabilize tests 5475bd0256

chore: exclude local worktree metadata e53908b594

fix: use portable flock nonblocking option 25319afaae

karsten added 1 commit 2026-11-05 15:34:00 +00:00

Merge Forgejo main and resolve continuation test overlap b811dcc58e

karsten merged commit 699967e481 into main 2026-11-05 15:34:51 +00:00

karsten referenced this pull request from a commit 2026-11-05 15:34:53 +00:00

Merge pull request 'fix: keep review behaviours out of Core defaults and stabilize tests' (#275) from fix/core-review-policy-forgejo into main

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

harness/core!275

No description provided.