fix: accept changeset-sized review submissions (input limit 1 MiB) #193
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "fix/review-transport-size"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Verified defect on the running 0.1.120 instance: review rounds on real changesets failed instantly with a swallowed exception. Root cause: review task input embeds the full changeset prompt (JSON-escaped diff); the submission validation capped input at 64,000 characters (src/execution.ts:292), so any changeset diff above ~64 KiB was rejected before the review worker ever started (no ledger entry, no worker session, round.error = generic reviewer-failure text).
Change: raise the execution submission input limit from 64,000 to 1 MiB. This covers the 512 KiB fail-closed changeset capture limit after JSON escaping (newlines double in JSON), including rounds context. Result/checkpoint/reply limits stay at 64,000.
Baseline: typecheck green, build green, 1106/1106 tests pass.
Review submissions embed the full changeset prompt; the 64,000-character submission limit rejected real changesets above 64 KiB instantly with a swallowed exception ('Reviewer failed, was cancelled, or returned invalid output'). Raise the submission input limit to 1 MiB, which covers the 512 KiB changeset limit after JSON escaping, matching the existing fail-closed changeset capture limit. Result/checkpoint/reply limits are unchanged.