fix: accept changeset-sized review submissions (input limit 1 MiB) #193

Merged
che-guevara merged 2 commits from fix/review-transport-size into main 2026-11-01 06:33:12 +00:00
Collaborator

Verified defect on the running 0.1.120 instance: review rounds on real changesets failed instantly with a swallowed exception. Root cause: review task input embeds the full changeset prompt (JSON-escaped diff); the submission validation capped input at 64,000 characters (src/execution.ts:292), so any changeset diff above ~64 KiB was rejected before the review worker ever started (no ledger entry, no worker session, round.error = generic reviewer-failure text).

Change: raise the execution submission input limit from 64,000 to 1 MiB. This covers the 512 KiB fail-closed changeset capture limit after JSON escaping (newlines double in JSON), including rounds context. Result/checkpoint/reply limits stay at 64,000.

  • src/execution.ts: submission validation input limit 64,000 -> 1 MiB
  • test/shared-execution.test.ts: submissions accept 700k chars, reject >1 MiB, durable across reload
  • docs/dispatcher.md + docs/review.md: documented submission cap and review transport sizing

Baseline: typecheck green, build green, 1106/1106 tests pass.

Verified defect on the running 0.1.120 instance: review rounds on real changesets failed instantly with a swallowed exception. Root cause: review task input embeds the full changeset prompt (JSON-escaped diff); the submission validation capped input at 64,000 characters (src/execution.ts:292), so any changeset diff above ~64 KiB was rejected before the review worker ever started (no ledger entry, no worker session, round.error = generic reviewer-failure text). Change: raise the execution submission input limit from 64,000 to 1 MiB. This covers the 512 KiB fail-closed changeset capture limit after JSON escaping (newlines double in JSON), including rounds context. Result/checkpoint/reply limits stay at 64,000. - src/execution.ts: submission validation input limit 64,000 -> 1 MiB - test/shared-execution.test.ts: submissions accept 700k chars, reject >1 MiB, durable across reload - docs/dispatcher.md + docs/review.md: documented submission cap and review transport sizing Baseline: typecheck green, build green, 1106/1106 tests pass.
Review submissions embed the full changeset prompt; the 64,000-character
submission limit rejected real changesets above 64 KiB instantly with a
swallowed exception ('Reviewer failed, was cancelled, or returned invalid
output'). Raise the submission input limit to 1 MiB, which covers the 512 KiB
changeset limit after JSON escaping, matching the existing fail-closed
changeset capture limit. Result/checkpoint/reply limits are unchanged.
Observed rounds on ~38 KiB review prompts were cancelled at the 120s
deadline while the flash provider was still computing (same prompt
measured 70s to 600s+ across attempts). Raise the dedicated review
worker deadline to 30 minutes so rounds absorb provider latency
variance while staying fail-closed for hung workers. Documented in
review.md.
Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
harness/core!193
No description provided.