harness/core
5
0
Fork 1
Code Issues Pull requests 15 Projects Releases 251 Packages 1 Wiki Activity Actions

test: await cron result delivery before harness drain #189

Open
randy-waterhouse wants to merge 1 commit from fix/cron-result-test-barrier into main
pull from: fix/cron-result-test-barrier
merge into: harness:main
Conversation 0 Commits 1 Files changed 1 +8 -2
randy-waterhouse commented 2026-10-31 19:48:26 +00:00
Member
Copy link

Purpose

Fix the diagnosed completion-barrier gap in one existing cron integration test, independently of native TLS PR #187. No runtime change.

Replace 30x10ms sleeps with waitForExecution -> flushEvents -> harness.drained. Preserve all existing assertions; additionally require one execution and an empty pending event list. Test timeout 15s bounds completion without weakening correctness.

Evidence

  • Focused cron tests 5/5, typecheck/build, diff check pass.
  • Independent exact-diff review a9a35bb7: no P0/P1; no assertions weakened.
  • Two unchanged TLS candidate full runs previously failed 1099/1100 on this synchronization gap. Isolated baseline/candidate cron suites passed; that did not establish full-suite green.
  • Combined isolated TLS+this-fix full suite running; result pending. No new green claim.

Dependency/delivery

Independently deployable test-only fix, no TLS source changes. PR #187 needs verification against this correction to close the known full-suite failure. Keep required CI/review. Neither PR is merged. Existing main-image promotion may restart agents automatically after merge, so publication is not activation permission.

## Purpose Fix the diagnosed completion-barrier gap in one existing cron integration test, independently of native TLS PR #187. No runtime change. Replace 30x10ms sleeps with waitForExecution -> flushEvents -> harness.drained. Preserve all existing assertions; additionally require one execution and an empty pending event list. Test timeout 15s bounds completion without weakening correctness. ## Evidence - Focused cron tests 5/5, typecheck/build, diff check pass. - Independent exact-diff review a9a35bb7: no P0/P1; no assertions weakened. - Two unchanged TLS candidate full runs previously failed 1099/1100 on this synchronization gap. Isolated baseline/candidate cron suites passed; that did not establish full-suite green. - Combined isolated TLS+this-fix full suite running; result pending. No new green claim. ## Dependency/delivery Independently deployable test-only fix, no TLS source changes. PR #187 needs verification against this correction to close the known full-suite failure. Keep required CI/review. Neither PR is merged. Existing main-image promotion may restart agents automatically after merge, so publication is not activation permission.
This pull request can be merged automatically.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin fix/cron-result-test-barrier:fix/cron-result-test-barrier
git switch fix/cron-result-test-barrier
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
harness/core!189
No description provided.