fix: tolerate invalid runtime overlay fields at startup and reload #180

Merged
severus-snape merged 1 commit from fix/runtime-overlay-tolerant into main 2026-10-31 13:20:15 +00:00
Collaborator

Requires #179. Dependent stacked correction; target feat/runtime-config-overlay-request at 2e310c129272b33545622533a2ab3b25a44e0761, NOT a standalone main change. Only the seven-file tolerant-overlay delta is included. Do not merge before #179; its implementation is a real dependency.

Apply supported valid overlay fields at both startup and reload while ignoring invalid or forbidden fields. Preserve existing explicit opt-in and config boundaries. No unrelated P2 fixes.

Known unit constraint (optional P2 from independent review): a nested pluginSpec with a bad sibling is discarded as a unit, e.g. valid disabled: true beside invalid module: 123. This PR does NOT claim universal leaf salvage. That follow-up is deliberately not batched here.

Evidence: existing 25 focused tests and typecheck passed; independent exact-tree review no P0/P1. Mandatory owner ReviewService on the actual staged seven-file tree and real home/cwd/base passed with no findings; fingerprint 66df9593dadb871694561de2720e54efb7a524179c82dff4d9202e236f48881c, tree 078bad32b88b10abc5875356a68682b4c0f8545b. One of three review rounds used; no history/approval borrowing or budget reset. Protected-operation assertions before and after commit passed; publication base equals the dependency head, not main.

No new implementation during delivery; PR179 and its worktree untouched. No merge, build/full-suite/CI polling, rollout, live configuration, restart, model HTTP or Che access. Publication only; leave open. Delivery evidence: /home/node/.vanillacore-harness/development-evidence/runtime-overlay-tolerant-pr-delivery.md.

Requires #179. Dependent stacked correction; target `feat/runtime-config-overlay-request` at `2e310c129272b33545622533a2ab3b25a44e0761`, NOT a standalone main change. Only the seven-file tolerant-overlay delta is included. Do not merge before #179; its implementation is a real dependency. Apply supported valid overlay fields at both startup and reload while ignoring invalid or forbidden fields. Preserve existing explicit opt-in and config boundaries. No unrelated P2 fixes. Known unit constraint (optional P2 from independent review): a nested pluginSpec with a bad sibling is discarded as a unit, e.g. valid `disabled: true` beside invalid `module: 123`. This PR does NOT claim universal leaf salvage. That follow-up is deliberately not batched here. Evidence: existing 25 focused tests and typecheck passed; independent exact-tree review no P0/P1. Mandatory owner ReviewService on the actual staged seven-file tree and real home/cwd/base passed with no findings; fingerprint `66df9593dadb871694561de2720e54efb7a524179c82dff4d9202e236f48881c`, tree `078bad32b88b10abc5875356a68682b4c0f8545b`. One of three review rounds used; no history/approval borrowing or budget reset. Protected-operation assertions before and after commit passed; publication base equals the dependency head, not main. No new implementation during delivery; PR179 and its worktree untouched. No merge, build/full-suite/CI polling, rollout, live configuration, restart, model HTTP or Che access. Publication only; leave open. Delivery evidence: `/home/node/.vanillacore-harness/development-evidence/runtime-overlay-tolerant-pr-delivery.md`.
severus-snape changed target branch from feat/runtime-config-overlay-request to main 2026-10-31 13:19:54 +00:00
Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
harness/core!180
No description provided.