harness/core
4
0
Fork 0
Code Issues Pull requests 1 Projects Releases 102 Packages 1 Wiki Activity Actions

fix: integrate notification routing with required dedicated review host #145

Merged
severus-snape merged 1 commit from fix/review-notification-main-integration into main 2026-10-28 11:47:28 +00:00
Conversation 0 Commits 1 Files changed 36 +1178 -33
severus-snape commented 2026-10-28 11:46:59 +00:00
Collaborator
Copy link

Scope and required dependency

Publish the exact independently reviewed source candidate 53a17a1d05af09b12fc68017dd25f5ee119d852c onto reviewed base 94191d6ce626a80667c7a991c0014647ce35b542 (PR144). This is one bounded compatibility changeset: conservative notification routing plus the dedicated review host required by the genuine production plugin pin 56082f1bb0c03513b920a722b2e3cd2fdbfcd0cd (plugins PR27, including PR26's mandatory dedicated-executor contract). Splitting off the host would leave that production pin incompatible; no hybrid lock or working-context self-review fallback is used.

  • Routine status only with explicit whole-reply classification and unchanged wait/next step; operator foreground answers, substantive results, errors and blockers remain chat. Persist routing across outbox retry/restart.
  • Dedicated dispatcher/subagent review execution, explicit isolated snapshot fallback, fail-closed missing executor and cancellation fencing.
  • Preserve PR141 live-parent authority, PR142 foreground/API settlement and PR144 productive wait-recheck accounting. PR143 is unrelated and excluded.
  • 36 source/test/docs files, 1178 additions / 33 deletions. No optional amendments.

Exact independent review and validation

FINAL independent review03ba52f4: no concrete reproducible P0/P1, bound to exact commit and full source hashes. Review ledger/history/budget unchanged. Historical review-tool status is not a substitute for this independent review.

  • Manifest SHA256: b1a800d8a640ebc967fbf7d41fca0b1e8cdec77a9c17d8d107207d621bc5beef
  • Full-index binary patch SHA256: 785937506d837d49b9ed813570f9dae7630096ab5c1143920d6aad68c09b4dfa
  • All 327 tracked hashes and evidence digests verified; independent review verified all 45 genuine materialized production plugin files.
  • Existing hash-bound evidence: 834/834 full tests, 127/127 focused, 34/34 contracts, 15/15 executors; build/typecheck successful. Fresh publication check: 47/47 integration/contract tests passed; diff --check passed.
  • Local evidence is not remote CI. Actual statuses, Actions and branch policy are inspected separately before any normal exact-head guarded merge. No force/admin bypass.

Nonblocking limits

Four documented P2 follow-ups only: snapshot does not bind runtime cwd; subagent restart provenance reconciles lazily; status dedup lacks recipient/thread; status adapter omits deliveryId. No optional changes bundled.

Evidence: /home/node/.vanillacore-harness/development-evidence/review-notification-main-integration/ (INDEPENDENT-REVIEW.md, manifest, full patch, test logs, publication API snapshots and PUBLICATION-RESULT.md). Source merge is not activation. No config/live-state/restart/deploy/GitOps or other-agent changes.

## Scope and required dependency Publish the exact independently reviewed source candidate `53a17a1d05af09b12fc68017dd25f5ee119d852c` onto reviewed base `94191d6ce626a80667c7a991c0014647ce35b542` (PR144). This is one bounded compatibility changeset: conservative notification routing plus the dedicated review host required by the genuine production plugin pin `56082f1bb0c03513b920a722b2e3cd2fdbfcd0cd` (plugins PR27, including PR26's mandatory dedicated-executor contract). Splitting off the host would leave that production pin incompatible; no hybrid lock or working-context self-review fallback is used. - Routine status only with explicit whole-reply classification and unchanged wait/next step; operator foreground answers, substantive results, errors and blockers remain chat. Persist routing across outbox retry/restart. - Dedicated dispatcher/subagent review execution, explicit isolated snapshot fallback, fail-closed missing executor and cancellation fencing. - Preserve PR141 live-parent authority, PR142 foreground/API settlement and PR144 productive wait-recheck accounting. PR143 is unrelated and excluded. - 36 source/test/docs files, 1178 additions / 33 deletions. No optional amendments. ## Exact independent review and validation FINAL independent review03ba52f4: no concrete reproducible P0/P1, bound to exact commit and full source hashes. Review ledger/history/budget unchanged. Historical review-tool status is not a substitute for this independent review. - Manifest SHA256: `b1a800d8a640ebc967fbf7d41fca0b1e8cdec77a9c17d8d107207d621bc5beef` - Full-index binary patch SHA256: `785937506d837d49b9ed813570f9dae7630096ab5c1143920d6aad68c09b4dfa` - All 327 tracked hashes and evidence digests verified; independent review verified all 45 genuine materialized production plugin files. - Existing hash-bound evidence: 834/834 full tests, 127/127 focused, 34/34 contracts, 15/15 executors; build/typecheck successful. Fresh publication check: 47/47 integration/contract tests passed; diff --check passed. - Local evidence is not remote CI. Actual statuses, Actions and branch policy are inspected separately before any normal exact-head guarded merge. No force/admin bypass. ## Nonblocking limits Four documented P2 follow-ups only: snapshot does not bind runtime cwd; subagent restart provenance reconciles lazily; status dedup lacks recipient/thread; status adapter omits deliveryId. No optional changes bundled. Evidence: `/home/node/.vanillacore-harness/development-evidence/review-notification-main-integration/` (`INDEPENDENT-REVIEW.md`, manifest, full patch, test logs, publication API snapshots and `PUBLICATION-RESULT.md`). Source merge is not activation. No config/live-state/restart/deploy/GitOps or other-agent changes.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
harness/core!145
No description provided.