feat: coherent review engine policy and tool selection #107

Merged
severus-snape merged 1 commit from feat/review-engine-selection into main 2026-10-27 07:21:22 +00:00
Collaborator

Scope

Close remaining review-policy/tool mismatch via trusted startup reviewEngine local ESM selection. Generic PolicyEngineModule apiVersion1/modelTools/create returns policies+plugins+required+instructions together. Selected custom module does not instantiate bundled ReviewService or register bundled plugin_review. Invalid module/composition fails startup, no fallback. Host configuration validates path, core PolicyRegistry validates policies and required IDs. Disabled review imports nothing. Explicit tools[] remains empty, nonempty includes selected names not hardcoded plugin_review.

No live ledger migration/reset/budget changes. Default remains compatible bundled engine. Startup only, not atomic runtime tool replacement. Generic trusted-code/no sandbox/prepare-only lifecycle documented. Host review configuration/model compatibility retained intentionally; not claimed universal config extraction.

Validation

Final585/585 tests/typecheck/build/diffcheck PASS. New integration loads actual custom ESM through loader, registers custom policy+tool, verifies bundled default factory never called and plugin_review/review absent, required identity protected; invalid/missing modules and missing required policy fail rather than fallback. Existing extraction/ledger/budget tests included unchanged.

Review/deploy

Author counterchecked diff; existing persistent review blockers0, no additional independent round/reset. Original dirty trees untouched. Merge/build not activation. Prior engine extraction PR106 now installed0.1.57/sourceed9b74b; this selection feature needs a later release. No own runtime engine config changes, no extra reviewer calls, no unrelated agent changes.

## Scope Close remaining review-policy/tool mismatch via trusted startup `reviewEngine` local ESM selection. Generic PolicyEngineModule apiVersion1/modelTools/create returns policies+plugins+required+instructions together. Selected custom module does not instantiate bundled ReviewService or register bundled plugin_review. Invalid module/composition fails startup, no fallback. Host configuration validates path, core PolicyRegistry validates policies and required IDs. Disabled review imports nothing. Explicit tools[] remains empty, nonempty includes selected names not hardcoded plugin_review. No live ledger migration/reset/budget changes. Default remains compatible bundled engine. Startup only, not atomic runtime tool replacement. Generic trusted-code/no sandbox/prepare-only lifecycle documented. Host review configuration/model compatibility retained intentionally; not claimed universal config extraction. ## Validation Final585/585 tests/typecheck/build/diffcheck PASS. New integration loads actual custom ESM through loader, registers custom policy+tool, verifies bundled default factory never called and plugin_review/review absent, required identity protected; invalid/missing modules and missing required policy fail rather than fallback. Existing extraction/ledger/budget tests included unchanged. ## Review/deploy Author counterchecked diff; existing persistent review blockers0, no additional independent round/reset. Original dirty trees untouched. Merge/build not activation. Prior engine extraction PR106 now installed0.1.57/sourceed9b74b; this selection feature needs a later release. No own runtime engine config changes, no extra reviewer calls, no unrelated agent changes.
Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
harness/core!107
No description provided.