harness/core
4
0
Fork 0
Code Issues Pull requests 7 Projects Releases 129 Packages 1 Wiki Activity Actions

fix: report truthful recovery diagnostic reasons #178

Open
severus-snape wants to merge 1 commit from fix/recovery-truthful-diagnostic into main
pull from: fix/recovery-truthful-diagnostic
merge into: harness:main
Conversation 0 Commits 1 Files changed 6 +99 -39
severus-snape commented 2026-10-31 12:02:09 +00:00
Collaborator
Copy link

Scope

Small independent recovery-diagnostic fix: distinguish invalid, exhausted, uncertain and technical evaluation failures instead of reporting an unsupported generic conclusion. Preserve the existing recovery budget and safe restart/outbox behavior. Exactly six files, based on main 4953b1f5c2; no dependency on open continuation-receipt PR #177.

Review and verification

  • Independently verified exact tree: 0a81f39885; patch SHA256 b0736adc54514754f6bb9710e47985807d65822a04a74fe10effba25a83e8918.
  • Retained implementation/independent verification: 37 focused tests passed, typecheck passed; no new full-suite/build/CI claim.
  • Independent exact-candidate review: no P0/P1 or concrete P2/P3 findings.
  • Normal owner ReviewService using original worktree and real home: passed, no findings, 1/3 rounds, no history, budget grants or reset. Fingerprint f5e5cc402356d71091ee55af052707c66b944dbc2d6d5eb678ff4f87cd24bc07 unchanged after commit; protected local/publish checks passed before and after commit.

Limits

Legacy state without a diagnostic remains neutral. A crash after claiming but before saving an evaluation cannot reconstruct a diagnostic; no extra attempt is spent collecting one. This does not assert anything about Peter's running report or active revision.

Leave OPEN for normal review and required CI. No merge, CI polling/rerun, rollout, restart, deployment, configuration or permissions change performed. Independent review is not rollout permission.

## Scope Small independent recovery-diagnostic fix: distinguish invalid, exhausted, uncertain and technical evaluation failures instead of reporting an unsupported generic conclusion. Preserve the existing recovery budget and safe restart/outbox behavior. Exactly six files, based on main 4953b1f5c28c4909ff7ed359bd1b92c0575e1005; no dependency on open continuation-receipt PR #177. ## Review and verification - Independently verified exact tree: 0a81f39885641ce287332d1029f17d95043b4cbf; patch SHA256 b0736adc54514754f6bb9710e47985807d65822a04a74fe10effba25a83e8918. - Retained implementation/independent verification: 37 focused tests passed, typecheck passed; no new full-suite/build/CI claim. - Independent exact-candidate review: no P0/P1 or concrete P2/P3 findings. - Normal owner ReviewService using original worktree and real home: passed, no findings, 1/3 rounds, no history, budget grants or reset. Fingerprint f5e5cc402356d71091ee55af052707c66b944dbc2d6d5eb678ff4f87cd24bc07 unchanged after commit; protected local/publish checks passed before and after commit. ## Limits Legacy state without a diagnostic remains neutral. A crash after claiming but before saving an evaluation cannot reconstruct a diagnostic; no extra attempt is spent collecting one. This does not assert anything about Peter's running report or active revision. Leave OPEN for normal review and required CI. No merge, CI polling/rerun, rollout, restart, deployment, configuration or permissions change performed. Independent review is not rollout permission.
This pull request has changes conflicting with the target branch.
  • src/completion-check.ts
  • src/harness.ts
  • test/actionable-recovery-attention.test.ts
View command line instructions

Manual merge helper

Use this merge commit message when completing the merge manually.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin fix/recovery-truthful-diagnostic:fix/recovery-truthful-diagnostic
git switch fix/recovery-truthful-diagnostic
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
harness/core!178
No description provided.